From 861158ad71effd4f48da442f5eb1bb70754eb08b Mon Sep 17 00:00:00 2001
From: Stef Walter <stef@memberwebs.com>
Date: Wed, 18 Aug 2004 22:15:10 +0000
Subject: Code cleanup

---
 apache1x/mod_httpauth.c | 1 -
 daemon/bd.c             | 1 -
 daemon/digest.c         | 2 --
 daemon/ldap.c           | 3 ---
 daemon/mysql.c          | 1 -
 5 files changed, 8 deletions(-)

diff --git a/apache1x/mod_httpauth.c b/apache1x/mod_httpauth.c
index 9f0d491..f710bcc 100644
--- a/apache1x/mod_httpauth.c
+++ b/apache1x/mod_httpauth.c
@@ -402,7 +402,6 @@ void disconnect_socket(httpauth_context_t* ctx, server_rec* s)
         ap_log_error(APLOG_MARK, APLOG_DEBUG, s,
                      "httpauth: disconnecting from daemon");
 
-        /* TODO: Should we be closing this nicely somewhere? */
         ap_pclosesocket(ctx->child_pool, ctx->socket);
         ctx->socket = -1;
         errno = 0;
diff --git a/daemon/bd.c b/daemon/bd.c
index a20b90b..e883fb4 100644
--- a/daemon/bd.c
+++ b/daemon/bd.c
@@ -454,7 +454,6 @@ const char* bd_substitute(const ha_request_t* rq, const char* user, const char*
     ASSERT(rq && user && str);
     ASSERT(ctx->f_escape_value);
 
-    /* TODO: We need to be escaping the user and realm properly */
     /* This starts a new block to join */
     ha_bufcpy(rq->buf, "");
 
diff --git a/daemon/digest.c b/daemon/digest.c
index 5d91995..e011690 100644
--- a/daemon/digest.c
+++ b/daemon/digest.c
@@ -229,8 +229,6 @@ int digest_pre_check(digest_context_t* dg, const ha_context_t* opts, ha_buffer_t
 {
     ASSERT(buf && buf && dg);
 
-    /* TODO: This stuff should probably go into bd.c */
-
     /* Check for digest */
     if(!dg->client.digest || !dg->client.digest[0])
     {
diff --git a/daemon/ldap.c b/daemon/ldap.c
index a302d3d..956c464 100644
--- a/daemon/ldap.c
+++ b/daemon/ldap.c
@@ -425,8 +425,6 @@ static LDAP* get_ldap_connection(const ha_request_t* rq, ldap_context_t* ctx)
 
     ASSERT(ctx);
 
-    /* TODO: What about multiple threads here? */
-
     for(i = 0; i < ctx->ldap_max; i++)
     {
         /* An open connection in the pool */
@@ -830,7 +828,6 @@ finally:
     if(ld)
         save_ldap_connection(rq, ctx, ld);
 
-    /* TODO: Check to make sure this fits within the return values */
     return ret;
 }
 
diff --git a/daemon/mysql.c b/daemon/mysql.c
index df2f8e2..0ed8f35 100644
--- a/daemon/mysql.c
+++ b/daemon/mysql.c
@@ -655,7 +655,6 @@ int mysql_config(ha_context_t* context, const char* name, const char* value)
 
     else if(strcmp(name, "dbtimeout") == 0)
     {
-        /* TODO: Implement database timeouts */
         return ha_confint(name, value, 0, 86400, &(ctx->mysql_timeout));
     }
 
-- 
cgit v1.2.3