From 32f0912fd6df69808bc25f012ce7694243025a35 Mon Sep 17 00:00:00 2001
From: Stef Walter <stef@thewalter.net>
Date: Tue, 2 Nov 2010 15:47:38 +0000
Subject: Track client authentication correctly.

---
 common/smtppass.c | 23 +++++++++++++++++++++++
 common/smtppass.h |  1 +
 2 files changed, 24 insertions(+)

diff --git a/common/smtppass.c b/common/smtppass.c
index d9b8cb5..7fcafd0 100644
--- a/common/smtppass.c
+++ b/common/smtppass.c
@@ -134,12 +134,14 @@ spthread_t;
 #define BDAT_CMD            "BDAT"
 #define XCLIENT_CMD         "XCLIENT"
 #define XFORWARD_CMD        "XFORWARD"
+#define AUTH_CMD            "AUTH"
 
 #define DATA_END_SIG        "." CRLF
 
 #define DATA_RSP            "354"
 #define OK_RSP              "250"
 #define START_RSP           "220"
+#define AUTH_SUCCESS_RSP    "235"
 
 #define RCVD_HEADER         "Received:"
 
@@ -893,6 +895,7 @@ static int smtp_passthru(spctx_t* ctx)
 
     int first_rsp = 1;      /* The first 220 response from server to be filtered */
     int filter_host = 0;    /* Next response is 250 hostname, which we change */
+    int auth_started = 0;   /* Started performing authentication */
 
     /* XCLIENT is for use in access control */
     int xclient_sup = 0;    /* Is XCLIENT supported? */
@@ -1038,6 +1041,12 @@ static int smtp_passthru(spctx_t* ctx)
                 continue;
             }
 
+            else if(is_first_word(C_LINE, AUTH_CMD, KL(AUTH_CMD)))
+            {
+                sp_messagex(ctx, LOG_DEBUG, "Tracking authentication");
+                auth_started = 1;
+            }
+
             /* All other commands just get passed through to server */
             if(spio_write_data(ctx, &(ctx->server), C_LINE) == -1)
                 RETURN(-1);
@@ -1211,6 +1220,20 @@ static int smtp_passthru(spctx_t* ctx)
                 {
                     cleanup_context(ctx);
                 }
+
+                /* Successful authentication */
+                else if(is_first_word(S_LINE, AUTH_SUCCESS_RSP, KL(AUTH_SUCCESS_RSP)))
+                {
+                    if(auth_started)
+                    {
+                        sp_messagex(ctx, LOG_DEBUG, "Client authenticated successfully");
+                        ctx->authenticated = 1;
+                    }
+                    else
+                    {
+                        sp_messagex(ctx, LOG_WARNING, "Authentication success code without AUTH");
+                    }
+                }
             }
 
             if(spio_write_data(ctx, &(ctx->client), S_LINE) == -1)
diff --git a/common/smtppass.h b/common/smtppass.h
index 8c2a6cf..0fbe458 100644
--- a/common/smtppass.h
+++ b/common/smtppass.h
@@ -134,6 +134,7 @@ typedef struct spctx
     char* recipients;               /* The email of the recipients */
     char* xforwardaddr;             /* The IP address proxied for */
     char* xforwardhelo;             /* The HELO/EHLO proxied for */
+    int authenticated;              /* Whether the client authenticated successfully */
 
     int _crlf;                      /* Private data */
 }
-- 
cgit v1.2.3